Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch scrolling #5

Closed
gemedet opened this issue Jun 4, 2016 · 11 comments
Closed

Touch scrolling #5

gemedet opened this issue Jun 4, 2016 · 11 comments
Assignees
Milestone

Comments

@gemedet
Copy link

gemedet commented Jun 4, 2016

Thanks for starting this repo! Any plans to support touch scrolling natively? This was a common question in the original issue tracker.

For reference:
facebookarchive/fixed-data-table#403
facebookarchive/fixed-data-table#365
facebookarchive/fixed-data-table#26

@wcjordan
Copy link
Member

wcjordan commented Jun 4, 2016

Kam and I are looking at adapting the code here and here to provide another scrolling handler similar to ReactWheelHandler.

The major challenge for us will be validating that the solution works on different devices and setups. Particularly the cases mentioned of plugging a touchscreen laptop into an external monitor with a mouse may be challenging.

As such, we'll try to release a beta solution sometime this week which only enables the functionality if a flag is passed in as a prop. We can then address any issues based on feedback. Thanks for reporting!

@KamranAsif KamranAsif mentioned this issue Jun 4, 2016
7 tasks
@KamranAsif KamranAsif reopened this Jun 4, 2016
@KamranAsif KamranAsif self-assigned this Jun 4, 2016
@KamranAsif
Copy link
Contributor

Have some basic functionality up behind a flag, as well as an example.
Would appreciate it if you could checkout the PR and test it for your use case :)

@gemedet
Copy link
Author

gemedet commented Jun 5, 2016

Awesome, that was fast! It seems to work when I start dragging, but if I move my finger to the side it stops scrolling vertically. See my note on #7 (comment).

@mahmoudfelfel
Copy link

Thanks for working on this,
I have a similar issue, can't scroll on mobile devices, is there any updates ?

@wcjordan
Copy link
Member

Hey @mahmoudfelfel, we have a PR up here which enables touch scrolling when a touchScrollEnabled={true} prop is passed into the table. Feel free to check it out and let us know if you find any issues with it.

Right now we're trying to resolve issues related to scroll stopping when your finger leaves the table and adding scroll deceleration so the scroll doesn't stop immediately when you remove your finger. I hope to have a more detailed update to you later this week.

@mahmoudfelfel
Copy link

@wcjordan thanks for your reply, and certainly will check the PR, test it, and give my feedback and will add comments on the PR for any issues i find.

@wcjordan
Copy link
Member

I've added some momentum scrolling when drag is released and some tuning to make scroll smooth here: wcjordan@bffbf89

I'll integrate it with Kam's open PR when I have a chance to sync with him.

@wcjordan wcjordan added this to the 0.6.6 milestone Jun 23, 2016
@wcjordan
Copy link
Member

We've merged this issue in and will release behind a flag as part of 0.6.6 shortly. I'll close for now, but please try it out and open new issues for any instability or lack of smoothness you find.

@weixing2014
Copy link
Contributor

@wcjordan Hi, do we have any plan to support touch scrolling natively on touchscreen PCs? It seems for the time being Fixed-data-table-2 can only be scrollable in Chrome on touchscreen PCs. Thanks!

@wcjordan
Copy link
Member

wcjordan commented Feb 3, 2017

I'd be open to PRs but don't want to get to into the thick of figuring out support for browsers which haven't implemented the Touch Events API. You're welcome to experiment with the binding here. If you find something that works, feel free to extract the logic into a component and submit a PR.

@weixing2014
Copy link
Contributor

Thanks, @wcjordan ! This is very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants