-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch scrolling #5
Comments
Kam and I are looking at adapting the code here and here to provide another scrolling handler similar to ReactWheelHandler. The major challenge for us will be validating that the solution works on different devices and setups. Particularly the cases mentioned of plugging a touchscreen laptop into an external monitor with a mouse may be challenging. As such, we'll try to release a beta solution sometime this week which only enables the functionality if a flag is passed in as a prop. We can then address any issues based on feedback. Thanks for reporting! |
Have some basic functionality up behind a flag, as well as an example. |
Awesome, that was fast! It seems to work when I start dragging, but if I move my finger to the side it stops scrolling vertically. See my note on #7 (comment). |
Thanks for working on this, |
Hey @mahmoudfelfel, we have a PR up here which enables touch scrolling when a touchScrollEnabled={true} prop is passed into the table. Feel free to check it out and let us know if you find any issues with it. Right now we're trying to resolve issues related to scroll stopping when your finger leaves the table and adding scroll deceleration so the scroll doesn't stop immediately when you remove your finger. I hope to have a more detailed update to you later this week. |
@wcjordan thanks for your reply, and certainly will check the PR, test it, and give my feedback and will add comments on the PR for any issues i find. |
I've added some momentum scrolling when drag is released and some tuning to make scroll smooth here: wcjordan@bffbf89 I'll integrate it with Kam's open PR when I have a chance to sync with him. |
We've merged this issue in and will release behind a flag as part of 0.6.6 shortly. I'll close for now, but please try it out and open new issues for any instability or lack of smoothness you find. |
@wcjordan Hi, do we have any plan to support touch scrolling natively on touchscreen PCs? It seems for the time being Fixed-data-table-2 can only be scrollable in Chrome on touchscreen PCs. Thanks! |
I'd be open to PRs but don't want to get to into the thick of figuring out support for browsers which haven't implemented the Touch Events API. You're welcome to experiment with the binding here. If you find something that works, feel free to extract the logic into a component and submit a PR. |
Thanks, @wcjordan ! This is very helpful. |
Thanks for starting this repo! Any plans to support touch scrolling natively? This was a common question in the original issue tracker.
For reference:
facebookarchive/fixed-data-table#403
facebookarchive/fixed-data-table#365
facebookarchive/fixed-data-table#26
The text was updated successfully, but these errors were encountered: