Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"site-dev-server" script doesn't work after upgrading to npm 9.8.0 #708

Closed
daniela-mateescu opened this issue Nov 27, 2023 · 4 comments · Fixed by #710
Closed

"site-dev-server" script doesn't work after upgrading to npm 9.8.0 #708

daniela-mateescu opened this issue Nov 27, 2023 · 4 comments · Fixed by #710
Assignees
Labels
bug help wanted Onboarding PRs or issues which serve as a good onboarding task

Comments

@daniela-mateescu
Copy link
Contributor

daniela-mateescu commented Nov 27, 2023

When running site-dev server I get the following error:
image
This line is causing the problem:
image
If I comment this line, the application starts.

I have npm version 9.8.0
The problem is that the npm bin command it doesn't exists anymore in this npm version As you can see:

image

on their official web page: https://docs.npmjs.com/cli/v7/commands/npm-bin

@daniela-mateescu daniela-mateescu changed the title "site-dev-server" script doesn't work after upgrading to node 9.8.0 "site-dev-server" script doesn't work after upgrading to npm9.8.0 Nov 27, 2023
@daniela-mateescu daniela-mateescu changed the title "site-dev-server" script doesn't work after upgrading to npm9.8.0 "site-dev-server" script doesn't work after upgrading to npm 9.8.0 Nov 27, 2023
@pradeepnschrodinger pradeepnschrodinger self-assigned this Dec 2, 2023
@pradeepnschrodinger pradeepnschrodinger added bug help wanted Onboarding PRs or issues which serve as a good onboarding task labels Dec 2, 2023
@pradeepnschrodinger
Copy link
Collaborator

Good find. I believe the script should just use npm exec or npx and not worry about where/how the node packages are executed.
This should be a quick fix, I'll experiment and put a PR soon.

@pradeepnschrodinger
Copy link
Collaborator

Fix put for review at #710.

@pradeepnschrodinger
Copy link
Collaborator

@daniela-mateescu , the fix for this is released with v2.0.4.

@daniela-mateescu
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Onboarding PRs or issues which serve as a good onboarding task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants