Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ray_interior_color atomic not working properly #120

Closed
giagitom opened this issue Jul 30, 2020 · 7 comments
Closed

ray_interior_color atomic not working properly #120

giagitom opened this issue Jul 30, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@giagitom
Copy link

Hi,
when I set ray_interior_color, atomic and render the scene i get a uniform coloring instead.
Screenshot 2020-07-30 14:56:25

@speleo3 speleo3 added the enhancement New feature or request label Jul 30, 2020
@speleo3
Copy link
Contributor

speleo3 commented Jul 30, 2020

I've marked this as a feature request. I think it's reasonable to support this, but want to spec out the expected behavior before implementing.

I assume you expect that a sphere with color yellow and ray_interior_color=atomic will have a yellow interior color (color of current primitive), and not the color you'd get from color atomic.

That would yield the following support table for ray_interior_color:

Setting valueEffective Color
named colornamed color
name of color ramp ramp lookup at front clipping plane
objectobject color
atomiccolor of current primitive (new)

Different contexts for the atomic color:

CommandEffect
colorAssigns element colors to atoms
ramp_newcolor of closest atom in proximity object
set ray_interior_color, atomicray interior coloring by current primitive color (new)

@giagitom
Copy link
Author

Yes, exactly.
It would be nice to implement this feature.

@speleo3 speleo3 closed this as completed in 8f5c06b Aug 6, 2020
@giagitom
Copy link
Author

giagitom commented Aug 6, 2020

Thank you @speleo3 i tried the new feature and looks really nice!

Would it be possible to scale (darken a bit) interior color when atomic coloring is set? This is to better discriminate internal from the external parts. I tried to scale interior color by 0.8 factor in the below image.

I also found strange artifacts when rendering spheres together with cartoons as you can see
Screenshot 2020-08-06 17:15:27

@speleo3
Copy link
Contributor

speleo3 commented Aug 6, 2020

@giagitom you can control the brightness to some extent with the direct and reflect settings.

Side note: I thought we now match lighting properly in ray tracing and shader rendering, but it appears not to be the case for these two settings.

Not sure if there is much we can do about the artifacts.

@giagitom
Copy link
Author

giagitom commented Aug 6, 2020

Thanks @speleo3 .

Do you know what is the cause of artifacts? Because it is not only related to cartoons only. If i apply any representation other than spheres to the scene it breaks color sorting for some reason.

@giagitom
Copy link
Author

giagitom commented Sep 4, 2020

Not sure if there is much we can do about the artifacts.

@speleo3 any news on the artifacts cause? I am wondering if you know why this is happening

@speleo3
Copy link
Contributor

speleo3 commented Sep 4, 2020

any news on the artifacts cause? I am wondering if you know why this is happening

We don't know yet, sorry :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants