Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wallaby.js config #11

Merged
merged 1 commit into from
Oct 6, 2015
Merged

Conversation

ArtemGovorov
Copy link
Contributor

Wallaby doesn't support complex patterns, so I have simplified it a bit. Now all tests pass with wallaby.js.

@tommyminds
Copy link
Contributor

Hey @ArtemGovorov. Thats strange! For me wallaby seems to be working fine with the complex pattern. But thanks for the tip!

tommyminds added a commit that referenced this pull request Oct 6, 2015
@tommyminds tommyminds merged commit bcee69c into sbp-archive:master Oct 6, 2015
@ArtemGovorov
Copy link
Contributor Author

You are actually right, it does work in Atom, not in WebStorm though, so the simplified one works across all editors.

@tommyminds
Copy link
Contributor

@ArtemGovorov Just out of curiosity, how did you find this repo and the fact that the tests were failing in WebStorm? ;)

@ArtemGovorov
Copy link
Contributor Author

@TommyM I'm a creator of wallaby.js and occasionally search GitHub for repos with wallaby configs in them to see how people are using it, in order to get a better idea about what I can improve, what technologies people use with wallaby more, etc.

@tommyminds
Copy link
Contributor

Alright, next-level support! Helping your users before they even realise they need help! :p Again, thanks for the PR.

We are really excited about wallaby.js and are planning on starting to leverage it in all our projects.

@ArtemGovorov
Copy link
Contributor Author

Heh, yes, kind of it :)
Awesome! You guys probably already know where to find me in case if I can help with any questions/issues regarding wallaby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants