Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic SQL DataSource #121

Merged
merged 7 commits into from May 26, 2020
Merged

Add generic SQL DataSource #121

merged 7 commits into from May 26, 2020

Conversation

schuderer
Copy link
Owner

@schuderer schuderer commented May 25, 2020 •
edited

Reference issues/PRs

Fix #109, an can act as a workaround that can close #4

What this implements/fixes

Adds an SQLAlchemy-based generic datasource to use with ODBC, etc. databases:

DataSource for RedShift, Postgres, MySQL, SQLite, Oracle, Microsoft SQL (ODBC), and their dialects.

This will hopefully lead to the mid- to long-term replacement of OracleDataSource, ImpalaDataSource etc.

Other comments

  • Still needs unit tests!
  • Add to builtin datasource docs
  • try to get rid of oyodbc-related warnings with cloudera impala odbc driver

@schuderer schuderer added the enhancement New feature or request label May 25, 2020
@schuderer schuderer mentioned this pull request May 26, 2020
Closed
@schuderer schuderer merged commit d1745d5 into master May 26, 2020
@schuderer schuderer added this to Done in Prioritized User Issues via automation May 26, 2020
@schuderer schuderer added this to the Unit Test Coverage >= 90% milestone May 27, 2020
@schuderer schuderer mentioned this pull request Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Prioritized User Issues
  
Done
Milestone
Unit Test Coverage >= 90%
Development

Successfully merging this pull request may close these issues.

Add an ODBC data source implementation Impala support (Hadoop)
1 participant
@schuderer