Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage >80% #46

Closed
6 tasks done
schuderer opened this issue Sep 30, 2019 · 1 comment · Fixed by #103
Closed
6 tasks done

Coverage >80% #46

schuderer opened this issue Sep 30, 2019 · 1 comment · Fixed by #103
Labels
help wanted Extra attention is needed
Projects
Release 1.0.0 tracker
Milestone
Unit Test Coverag...

Comments

@schuderer
Copy link
Owner

schuderer commented Sep 30, 2019 •
edited

Increase Unit Test coverage to a sane level

Next quick wins (in order of decreasing bang for the buck):

  • tests for resource.py (wanted anyway in preparation of issues Impala support (Hadoop) #4 and HIVE Support (Hadoop) #5)
  • ignore almost empty __main__.py (or simply do import in cli-tests; sub-1%-change)
  • Tests for cli.py (as part of PR Change CLI to Click #77), should yield another 5% points (reality: about 3%)
  • Tests for model_actions.py, should yield another ~10% points
  • Test helper functions in api.py, and maybe some more important branches, ca. +10% points (reality: about 3%)
  • [/] Test coverage-ignored __name__ == "__main__" branch in wsgi.py

Also:

  • Set the minimum coverage to 80% in noxfile

Edit: added todos.
@schuderer schuderer added this to To do in Release 1.0.0 tracker via automation Sep 30, 2019
@schuderer schuderer added the help wanted Extra attention is needed label Sep 30, 2019
@schuderer schuderer mentioned this issue Mar 31, 2020
Merged
@schuderer
Copy link
Owner Author

schuderer commented Apr 3, 2020 •
edited

Got it to just under 65% with the DataSource-related tests. 😅

@schuderer schuderer moved this from To do to In progress in Release 1.0.0 tracker Apr 3, 2020
This was referenced Apr 21, 2020
Merged
Merged
Merged
Release 1.0.0 tracker automation moved this from In progress to Done Apr 23, 2020
@schuderer schuderer added this to the Unit Test Coverage >= 90% milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
No open projects
Release 1.0.0 tracker
  
Done
Milestone
Unit Test Coverage >= 90%
Development

Successfully merging a pull request may close this issue.

Release 0.1.2 schuderer/mllaunchpad
1 participant
@schuderer