-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It is said searchType is deprecated. Does this affect to the pacakge? #35
Comments
Hey, thanks for pointing out and I definitely will change it, but not sure exactly when I have the time in the next weeks. Since there is no one complaining so far, i guess the deprecated searchType is still working at the moment. |
You're welcome ! I think It is better to close the issue only after the update. |
Hi @schulzefelix ! , Just checking back again. Wondering whether you had time to look into this ! . Actually to get discover and googlenews type results we have to send the "type" parameter I think. can you suggest me where I should do this change in my fork? Thanks |
Hey, thanks for the ping and I actually looked into this. As it turns out it seems the whole package needs a complete rewrite because the underlaying Google API changed, I hope mostly just the naming from Webmaster to SearchConsole and new functions, but we will know along the way. There is no simply way in this state to replace searchType with type, since the new type parameter isn't in the old classes. |
Refer : https://developers.google.com/webmaster-tools/v1/searchanalytics/query.
Thanks for this amazing laravel package!
Just wanted to know this before starting a new project.
The text was updated successfully, but these errors were encountered: