This repository has been archived by the owner on Feb 25, 2022. It is now read-only.
Introduce config flag for N26 to only import processed transactions #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the values that we get from the (not official) N26 API change from time to time, people often end up with duplicated transactions. There as already been effort in avoiding that (#16) but it is still happening. This PR will introduce a new config flag for the [N26 Dumper](https://github.com/schurig/ynab-bank-importer/wiki/n26) called `skip_pending_transactions`. This setting will be set to `false` by default. When set to true, all transactions that are still pending _(= not processed by N26)_ won't be imported by the script until they are processed. This will prevent duplicate entries but comes with the tradeoff that it might take a few days for transactions to show up in your YNAB.
The calculated_timestamp method was used to resolve the timezone issue from N26. But for this to work we needed to find out the currect offset. And because the UTC-offset changes twice a year, this code stopped working properly with the latest daylight-saving time change.
|
Oh, never noticed this one! We finally figured this out. Great :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background story
Because the values that we get from the (not official) N26 API change from time to time, people often end up with duplicated transactions.
There has already been effort in avoiding that but it is still happening.
What the PR will do
This PR will introduce a new config flag for the N26 Dumper called
skip_pending_transactions.This setting will be set to
falseby default. When set to true, all transactions that are still pending (= not processed by N26) won't be imported by the script until they are processed.This will prevent duplicate entries but comes with the tradeoff that it might take a few days for transactions to show up in your YNAB.
The PR will fix #36.