Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport content does not stretch if it overflows the viewport boundaries horizontally #77

Closed
danielwiehl opened this issue Jan 14, 2019 · 0 comments

Comments

@danielwiehl
Copy link
Collaborator

danielwiehl commented Jan 14, 2019

If some content inside a <sci-viewport> horizontally overflows the viewport boundaries, the viewport correctly shows a horizontal scrollbar. However, when scrolling to the right, background color does not extend to the right and flex items do not stretch.

For that reason, the display of the viewport should be changed from 'flex' to 'grid'. By default, this creates a single column layout which by default stretches its content as expected. If using a flex layout, stretching the flex item has not the desired effect.

@danielwiehl danielwiehl self-assigned this Jan 14, 2019
danielwiehl added a commit that referenced this issue Jan 16, 2019
If some content horizontally overflows the viewport boundaries, the viewport correctly shows a horizontal scrollbar. However, when scrolling to the right, background color does not extend to the right and child flex items do not stretch.

For that reason, the display of the viewport is changed from 'flex' to 'grid'. By default, this creates a single column layout which by default stretches its content as expected. If using a flex layout, stretching the flex item would not have the desired effect.

Closes #77

BREAKING CHANGE: CSS display property of <sci-viewport> flex container has changed from `flex` (column nowrap) to `grid` (one column).

To migrate:
- if having a single content child which stretches vertically by using `flex: auto`, remove that property
- if having multiple content children with `flex: none`, wrap them inside a separate flex-container
danielwiehl added a commit that referenced this issue Jan 18, 2019
If some content horizontally overflows the viewport boundaries, the viewport correctly shows a horizontal scrollbar. However, when scrolling to the right, background color does not extend to the right and child flex items do not stretch.

For that reason, the display of the viewport is changed from 'flex' to 'grid'. By default, this creates a single column layout which by default stretches its content as expected. If using a flex layout, stretching the flex item would not have the desired effect.

fixes #77

BREAKING CHANGE: CSS display property of <sci-viewport> flex container has changed from `flex` (column nowrap) to `grid` (one column).

To migrate:
- if having a single content child which stretches vertically by using `flex: auto`, remove that property
- if having multiple content children with `flex: none`, wrap them inside a separate flex-container
danielwiehl added a commit that referenced this issue Jan 21, 2019
If some content horizontally overflows the viewport boundaries, the viewport correctly shows a horizontal scrollbar. However, when scrolling to the right, background color does not extend to the right and child flex items do not stretch.

For that reason, the display of the viewport is changed from 'flex' to 'grid'. By default, this creates a single column layout which by default stretches its content as expected. If using a flex layout, stretching the flex item would not have the desired effect.

fixes #77

BREAKING CHANGE: CSS display property of <sci-viewport> flex container has changed from `flex` (column nowrap) to `grid` (one column).

To migrate:
- if having a single content child which stretches vertically by using `flex: auto`, remove that property
- if having multiple content children with `flex: none`, wrap them inside a separate flex-container
danielwiehl added a commit that referenced this issue Jan 28, 2019
If some content horizontally overflows the viewport boundaries, the viewport correctly shows a horizontal scrollbar. However, when scrolling to the right, background color does not extend to the right and child flex items do not stretch.

For that reason, the display of the viewport is changed from 'flex' to 'grid'. By default, this creates a single column layout which by default stretches its content as expected. If using a flex layout, stretching the flex item would not have the desired effect.

fixes #77

BREAKING CHANGE: CSS display property of <sci-viewport> flex container has changed from `flex` (column nowrap) to `grid` (one column).

To migrate:
- if having a single content child which stretches vertically by using `flex: auto`, remove that property
- if having multiple content children with `flex: none`, wrap them inside a separate flex-container
danielwiehl added a commit that referenced this issue Jan 29, 2019
If some content horizontally overflows the viewport boundaries, the viewport correctly shows a horizontal scrollbar. However, when scrolling to the right, background color does not extend to the right and child flex items do not stretch.

For that reason, the display of the viewport is changed from 'flex' to 'grid'. By default, this creates a single column layout which by default stretches its content as expected. If using a flex layout, stretching the flex item would not have the desired effect.

fixes #77

BREAKING CHANGE: CSS display property of <sci-viewport> flex container has changed from `flex` (column nowrap) to `grid` (one column).

To migrate:
- if having a single content child which stretches vertically by using `flex: auto`, remove that property
- if having multiple content children with `flex: none`, wrap them inside a separate flex-container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant