Add "signature_error_handler" method. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subclasses can override signature_error_handler to do something other than just die() with the message generated by signature_error.
|
Looks like this got dropped on the floor. Sounds like a good idea to me. +1 Perhaps it can be extended to cover other error messages we have? (Not a merge stopper) |
|
Yeah, that's my fault. I was on sabbatical, and I let this stew for too long. I'll take a closer look and try to get it merged in this weekend. |
barefootcoder
added a commit
that referenced
this pull request
Feb 17, 2013
part of cleaning up larryl's fix for #54
barefootcoder
added a commit
that referenced
this pull request
Feb 17, 2013
part of cleaning up larryl's fix for #54
barefootcoder
added a commit
that referenced
this pull request
Feb 17, 2013
part of cleaning up larryl's fix for #54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subclasses can override signature_error_handler to do something
other than just die() with the message generated by signature_error.