Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pipelinexxx macros #54

Closed
behrica opened this issue Oct 31, 2021 · 5 comments · Fixed by #56
Closed

remove pipelinexxx macros #54

behrica opened this issue Oct 31, 2021 · 5 comments · Fixed by #56

Comments

@behrica
Copy link
Member

behrica commented Oct 31, 2021

Starting here:

They are all in metamorph:
https://github.com/scicloj/metamorph

@genmeblog
Copy link
Member

But this way we make pipeline napespace not usable without metamorph which is not a dependency of the library.

What about removing pipeline completely?

@behrica
Copy link
Member Author

behrica commented Nov 15, 2021

But this way we make pipeline napespace not usable without metamorph which is not a dependency of the library.

That is not a problem. The code of the functions is "repeated" and started to diverge already. So we have maintenance costs.

What about removing pipeline completely?
That would break backwards compatibility heavely.
The remaining code has "no maintenance cost", as it just auto generates functions. Its 'free beer".

I do agree that the pipeline namespace could have been avoided altogether.
scicloj.ml should have run the generation on the fly.

But it is there and does not harm in my view.
Same in TMD itself:
https://github.com/techascent/tech.ml.dataset/blob/master/src/tech/v3/dataset/metamorph.clj
Here we have only the function generation.

If we "remove completely" we should do on "one go" for TC + TMD together (and move to scicloj.ml) , announcing it properly.

@behrica
Copy link
Member Author

behrica commented Nov 15, 2021

Then it would stay "invisible" for scicloj users, if there are any....
Maybe this PR first to avoid having real duplication (and divergence) in the pipeline functions.

@behrica
Copy link
Member Author

behrica commented Nov 15, 2021

And then we think about a simultaneous change of TMD / TC + scicloj.ml, to move the generation here:
https://github.com/scicloj/scicloj.ml/blob/main/src/scicloj/ml/metamorph.clj

So instead of export-xxx we do generate-xxx

@genmeblog
Copy link
Member

Agreed. Will merge PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants