Typos in the Source Code

[mishkov]

Hello there 👋

I think I found the typo in the rfft documentation:

scidart/lib/src/scidart/fftpack/rfft/rfft.dart

Line 5 in 201ca58

/// - [x] A Array with the input

Please correct me if I am wrong. But if it is typo, can I create a pull request to fix it?

One more typo in the fft.dart comment:

scidart/lib/src/scidart/fftpack/fft/fft.dart

Line 74 in f149050

// It is power of 2, apply cooley turkey algorithm

As I know there is no "cooley turkey algorithm" 🙂

[polotto]

You can do a PR to fix the typos, that will improve the documentation. About the Cooley Tukey, this is official name of FFT algorithm (https://en.wikipedia.org/wiki/Cooley%E2%80%93Tukey_FFT_algorithm). There are a plenty of them: DFT recursive, DFT divide and conquer, FFT Cooley Tukey, FFT for non power of 2 (Chirp-z / Bluestein's algorithm), etc.

[mishkov]

I mean, is the letter "r" definitely in the name "Cooley Turkey"?

It looks confusing.

[polotto]

I got it. Yes, It's a mistake... anyway, go ahead do the PR fixing all the typos.

[mishkov]

Ok.

[polotto]

Hello there

Will you do a PR to fix these typos? I need to close this issue.

[mishkov]

Fixed typos is merged

[polotto]

Update to 0.0.2-dev.7 to get your PR.