Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH100 check looks for .yml and not .yaml, presumably #267

Closed
Andrew-S-Rosen opened this issue Aug 23, 2023 · 1 comment · Fixed by #268
Closed

GH100 check looks for .yml and not .yaml, presumably #267

Andrew-S-Rosen opened this issue Aug 23, 2023 · 1 comment · Fixed by #268

Comments

@Andrew-S-Rosen
Copy link

https://scientific-python.github.io/repo-review/?repo=Quantum-Accelerators%2Fquacc&branch=main

In running the above test, GH100 gets raised and states that there are no .yml files in .github/workflows. While this is indeed true, there are .yaml files which are equally valid. This seems like a simple parsing issue.

@henryiii
Copy link
Collaborator

henryiii commented Aug 23, 2023

if workflow_path.name.endswith(".yml"):

(Globbing, technically, not parsing)

@henryiii henryiii transferred this issue from scientific-python/repo-review Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants