Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest changes to ls failing in Windows 10 for sub-directories #60

Open
joewez opened this issue Aug 2, 2018 · 9 comments
Open

Latest changes to ls failing in Windows 10 for sub-directories #60

joewez opened this issue Aug 2, 2018 · 9 comments

Comments

@joewez
Copy link

joewez commented Aug 2, 2018

Upgrading to 1.0.5...

I can no longer list files in a subdirectory...

D:\Development>ampy -p com4 -b 115200 ls /wwwroot/ Traceback (most recent call last): File "C:\Users\Joseph\AppData\Local\Programs\Python\Python36-32\Scripts\ampy-script.py", line 11, in <module> load_entry_point('adafruit-ampy==1.0.5', 'console_scripts', 'ampy')() File "c:\users\joseph\appdata\local\programs\python\python36-32\lib\site-packages\click\core.py", line 722, in __call__ return self.main(*args, **kwargs) File "c:\users\joseph\appdata\local\programs\python\python36-32\lib\site-packages\click\core.py", line 697, in main rv = self.invoke(ctx) File "c:\users\joseph\appdata\local\programs\python\python36-32\lib\site-packages\click\core.py", line 1066, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "c:\users\joseph\appdata\local\programs\python\python36-32\lib\site-packages\click\core.py", line 895, in invoke return ctx.invoke(self.callback, **ctx.params) File "c:\users\joseph\appdata\local\programs\python\python36-32\lib\site-packages\click\core.py", line 535, in invoke return callback(*args, **kwargs) File "c:\users\joseph\appdata\local\programs\python\python36-32\lib\site-packages\ampy\cli.py", line 162, in ls for f in board_files.ls(directory, long_format=long_format): File "c:\users\joseph\appdata\local\programs\python\python36-32\lib\site-packages\ampy\files.py", line 124, in ls raise ex File "c:\users\joseph\appdata\local\programs\python\python36-32\lib\site-packages\ampy\files.py", line 117, in ls out = self._pyboard.exec_(textwrap.dedent(command)) File "c:\users\joseph\appdata\local\programs\python\python36-32\lib\site-packages\ampy\pyboard.py", line 267, in exec_ raise PyboardError('exception', ret, ret_err) ampy.pyboard.PyboardError: ('exception', b'', b'Traceback (most recent call last):\r\n File "<stdin>", line 6, in <module>\r\nOSError: [Errno 22] EINVAL\r\n')

@miketeachman
Copy link
Contributor

Same for Windows 7

@devxpy
Copy link
Member

devxpy commented Sep 2, 2018

Can you post the output without any arguments?

$ ampy -p com4 -b 115200 ls

Sidenote: please use the correct markdown. Put multi-line code in between 3 backticks

image

@joewez
Copy link
Author

joewez commented Sep 2, 2018

OK...

'''
C:\Users\Joseph>ampy -p com4 -b 115200 ls
boot.py
adc_test.py
app.py
aps_trusted.py
battlebot.py
bitmapfont.py
blink.py
bmp180_display.py
bmp180_test.py
button_async.py
button_dots.py
button_init.py
button_irq.py
button_test.py
captive_page.py
captive_server.py
carlos_clock.py
clock_demo.py
compass_test.py
config.py
custom_oled_test.py
dht_matrix.py
dht11_test.py
digit_clock.py
digit_test.py
dns_server.py
dnsquery.py
ds18b20_test.py
encoder_test.py
font5x8.bin
guess.py
gyro_test.py
hardware.py
hotspot_ftp.py
hotspot_web.py
initap.py
initwifi.py
lcd_test_1602.py
lcd_test_2004.py
life.py
lights.py
main.py
mastermind.py
matrix_bug.py
matrix_bug_blue.py
matrix_bug_red.py
matrix_demo.py
matrix_demo_blue.py
matrix_demo_red.py
matrix_particle.py
matrix_particle_red.py
matrix_read.py
matrix_read_blue.py
matrix_read_forever.py
matrix_scroll.py
matrix_scroll_blue.py
matrix_test.py
matrix_worm.py
matrix_worm_red.py
mqtt_test.py
npsoff.py
npstest.py
oled_demo.py
oled_demo2.py
oled_test.py
pcd_small.py
pcd_test.py
pixel.py
rgb.py
rtc.py
rtc_set.py
rtc_test.py
servo_demo.py
smalltext_test.py
smalltext_test2.py
starwars.py
strandtest.py
tft_test.py
tft_text.py
therm_test.py
thermo_demo.py
thermo_demo2.py
timers.py
tm1640_test.py
tones.py
uhttp.py
webrepl_cfg.py
widget.py
wifiboot.py
work_timer.py
wrapper.py
ws2812b_test.py
connect
dev
drivers
frozen
graphics
misc
profile
shields
umqtt
wwwroot
test.py
tft_dimensions.py
tft_random.py
tft_puzzle.py
tft_shield_test.py
tft_shield_test2.py
tft_shield_test3.py

C:\Users\Joseph>
'''

@joewez
Copy link
Author

joewez commented Sep 2, 2018

Here is another try at a subdirectory...

'''
C:\Users\Joseph>ampy -p com4 -b 115200 ls wwwroot
Traceback (most recent call last):
File "C:\Users\Joseph\AppData\Local\Programs\Python\Python37\Scripts\ampy-script.py", line 11, in
load_entry_point('adafruit-ampy==1.0.5', 'console_scripts', 'ampy')()
File "c:\users\joseph\appdata\local\programs\python\python37\lib\site-packages\click\core.py", line 722, in call
return self.main(*args, **kwargs)
File "c:\users\joseph\appdata\local\programs\python\python37\lib\site-packages\click\core.py", line 697, in main
rv = self.invoke(ctx)
File "c:\users\joseph\appdata\local\programs\python\python37\lib\site-packages\click\core.py", line 1066, in invoke
return process_result(sub_ctx.command.invoke(sub_ctx))
File "c:\users\joseph\appdata\local\programs\python\python37\lib\site-packages\click\core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "c:\users\joseph\appdata\local\programs\python\python37\lib\site-packages\click\core.py", line 535, in invoke
return callback(*args, **kwargs)
File "c:\users\joseph\appdata\local\programs\python\python37\lib\site-packages\ampy\cli.py", line 162, in ls
for f in board_files.ls(directory, long_format=long_format):
File "c:\users\joseph\appdata\local\programs\python\python37\lib\site-packages\ampy\files.py", line 124, in ls
raise ex
File "c:\users\joseph\appdata\local\programs\python\python37\lib\site-packages\ampy\files.py", line 117, in ls
out = self.pyboard.exec(textwrap.dedent(command))
File "c:\users\joseph\appdata\local\programs\python\python37\lib\site-packages\ampy\pyboard.py", line 267, in exec

raise PyboardError('exception', ret, ret_err)
ampy.pyboard.PyboardError: ('exception', b'', b'Traceback (most recent call last):\r\n File "", line 6, in \r\nOSError: [Errno 22] EINVAL\r\n')

C:\Users\Joseph>
'''

@devxpy
Copy link
Member

devxpy commented Sep 2, 2018

Have you tried prefixing the directory by a slash (/)?

Also, if you can, try this out using the master branch

$ git clone https://github.com/adafruit/ampy.git
$ cd ampy
$ pip install -e .

@joewez
Copy link
Author

joewez commented Sep 2, 2018

Adding the slash prefix makes no difference with 1.0.5.

The good new is that the master branch seems to work...

'''
D:\Development\ampy>ampy -p com4 -b 115200 ls wwwroot
/wwwroot/afm.html
/wwwroot/applications.html
/wwwroot/editkeys.html
/wwwroot/getting.html
/wwwroot/images
/wwwroot/index.html
/wwwroot/reference.html
/wwwroot/replintro.html
/wwwroot/resources.html
/wwwroot/scripts
/wwwroot/styles
/wwwroot/usage.html

D:\Development\ampy>
'''

Although it does hang when I do add the slash....FYI.

@devxpy
Copy link
Member

devxpy commented Sep 2, 2018

Alright. The master branch works because of this pull request.

Will check out why it hangs.

@jerryneedell
Copy link

FWIW - on my linux box the subdir listing works - except for lib/

jerryneedell@Ubuntu-Macmini:~/projects/nrf52840/circuitpython$ ampy -p /dev/ttyUSB0 ls -r
/boot.py
/junk.py
/lib/adafruit_bus_device/__init__.py
/lib/adafruit_bus_device/i2c_device.mpy
/lib/adafruit_bus_device/spi_device.mpy
/lib/adafruit_sdcard.mpy
/main.py
/more_junk.py
/stuff.py
/test_boot.py
jerryneedell@Ubuntu-Macmini:~/projects/nrf52840/circuitpython$ ampy -p /dev/ttyUSB0 ls lib -r
/lib/adafruit_bus_device/__init__.py
/lib/adafruit_bus_device/i2c_device.mpy
/lib/adafruit_bus_device/spi_device.mpy
/lib/adafruit_sdcard.mpy
jerryneedell@Ubuntu-Macmini:~/projects/nrf52840/circuitpython$ ampy -p /dev/ttyUSB0 ls /lib -r
/lib/adafruit_bus_device/__init__.py
/lib/adafruit_bus_device/i2c_device.mpy
/lib/adafruit_bus_device/spi_device.mpy
/lib/adafruit_sdcard.mpy
jerryneedell@Ubuntu-Macmini:~/projects/nrf52840/circuitpython$ ampy -p /dev/ttyUSB0 ls lib/ -r
Traceback (most recent call last):
  File "/usr/local/bin/ampy", line 11, in <module>
    load_entry_point('adafruit-ampy==1.0.5', 'console_scripts', 'ampy')()
  File "/usr/local/lib/python3.6/dist-packages/click-6.7-py3.6.egg/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/click-6.7-py3.6.egg/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.6/dist-packages/click-6.7-py3.6.egg/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.6/dist-packages/click-6.7-py3.6.egg/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.6/dist-packages/click-6.7-py3.6.egg/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/adafruit_ampy-1.0.5-py3.6.egg/ampy/cli.py", line 194, in ls
  File "/usr/local/lib/python3.6/dist-packages/adafruit_ampy-1.0.5-py3.6.egg/ampy/files.py", line 171, in ls
  File "/usr/local/lib/python3.6/dist-packages/adafruit_ampy-1.0.5-py3.6.egg/ampy/files.py", line 164, in ls
  File "/usr/local/lib/python3.6/dist-packages/adafruit_ampy-1.0.5-py3.6.egg/ampy/pyboard.py", line 267, in exec_
ampy.pyboard.PyboardError: ('exception', b'', b'Traceback (most recent call last):\r\n  File "<stdin>", line 34, in <module>\r\n  File "<stdin>", line 31, in listdir\r\n  File "<stdin>", line 14, in _listdir\r\nOSError: [Errno 22] EINVAL\r\n')
jerryneedell@Ubuntu-Macmini:~/projects/nrf52840/circuitpython$ 

@ladyada
Copy link
Collaborator

ladyada commented Jan 21, 2019

Hiya! We are discontinuing support for ampy, and will no longer be maintaining it. We are leaving this repository available for continued use. If you would like to take over supporting it, please contact us on the Adafruit Discord server and we can transfer the repository to you.
If you wish to continue developing it on your own, please fork the repository.

@ladyada ladyada closed this as completed Jan 21, 2019
@devxpy devxpy reopened this Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants