Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action buttons missing from works when logged in #179

Closed
KatharineV opened this issue Apr 12, 2024 · 4 comments
Closed

Action buttons missing from works when logged in #179

KatharineV opened this issue Apr 12, 2024 · 4 comments
Assignees
Labels
bug something isn't working Knapsack Upgrade

Comments

@KatharineV
Copy link

After the Knapsack upgrade, action buttons are missing from works on production. The buttons we expect to see are Edit, Delete, Attach Child, Add to Collection, and Feature. See screenshots below for an example of ADL staging (with buttons) compared to ADL and SDAPI prod (no buttons).

Staging with buttons:

https://adl.s2.adventistdigitallibrary.org/concern/images/p005873_clinton_theological_seminary_sextelles_1921?locale=en
Image

Prod without buttons:

https://adl.b2.adventistdigitallibrary.org/concern/published_works/22266468_cardinal_1986
Image

https://sdapi.b2.adventistdigitallibrary.org/concern/journal_articles/davarlogos_2023_2_59_93_the_compatibility_of_christ_s_ascension_in_the_epis?locale=en
Image

@KatharineV KatharineV added bug something isn't working Knapsack Upgrade labels Apr 12, 2024
ShanaLMoore referenced this issue Apr 13, 2024
@ShanaLMoore ShanaLMoore self-assigned this Apr 13, 2024
ShanaLMoore referenced this issue Apr 15, 2024
Action buttons were missing post knapsack deploy to prod

Issue:
- https://github.com/scientist-softserv/adventist-dl/issues/747

## BEFORE (action buttons should not show)
![Screenshot 2024-04-12 at 19-54-34 Adv_Linguist_and_Scholar pdf - Page
1
c29aaa2b-615d-41aa-91c0-eceec2d3e441](https://github.com/scientist-softserv/adventist_knapsack/assets/10081604/ccdac422-d9b8-4615-ab6e-42916750da6f)


## AFTER (action buttons should display)
![Screenshot 2024-04-12 at 19-54-46 Adv_Linguist_and_Scholar pdf - Page
1
c29aaa2b-615d-41aa-91c0-eceec2d3e441](https://github.com/scientist-softserv/adventist_knapsack/assets/10081604/5848d02b-f96c-454d-a390-cd205535d152)


### AFTER WHEN USER IS LOGGED OUT (buttons should not show)
![Screenshot 2024-04-12 at 19-55-10 Adv_Linguist_and_Scholar pdf - Page
1
c29aaa2b-615d-41aa-91c0-eceec2d3e441](https://github.com/scientist-softserv/adventist_knapsack/assets/10081604/f6b4bd26-0261-4dfb-bfe0-7ad02e0b897c)
@ShanaLMoore
Copy link
Contributor

Pass: ✅

STAGING

Image

@KatharineV
Copy link
Author

Confirmed that action items are showing on ADL and SDAPI production and staging when I am logged in. Screenshots below are just production. Note that we're seeing the "Public" tag, which wasn't present before. At some point that was masked in our instance of Hyku. Not sure when it came back, but it seems like Knapsack revealed it, since the pre-Knapsack staging screenshot at the top of the ticket doesn't include the Public visibility tag.

Note also that the location and look of the action buttons has changed. That's inconsequential and I don't want the team to waste time moving the buttons, but I would like to see the Public visibility tag go away, at least for visitors who are not logged in. When viewing works while logged out, there's no point to the visibility tag. If you can see it, it's public, so the tag is clutter. Can it go away? Does this need its own ticket, or is it related to the other buttons at the top of a work?

ADL
Image

SDAPI
Image

@ShanaLMoore
Copy link
Contributor

@KatharineV I'm going to create a new ticket for the public tag issue. If you are ok with the buttons as they are, please consider re verifying. Otherwise we can also make a ticket to change their position.

@KatharineV
Copy link
Author

Thanks, @ShanaLMoore . I'll move this ticket to done, since the buttons are present and they work. I really don't think the button location matters at all, as long as they're close to where people will look for them, and they work.

@kirkkwang kirkkwang transferred this issue from scientist-softserv/adventist-dl May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working Knapsack Upgrade
Projects
Status: Done
Status: Done
Development

No branches or pull requests

3 participants