Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection title displays white #196

Closed
1 task
ShanaLMoore opened this issue Feb 13, 2024 · 2 comments
Closed
1 task

Collection title displays white #196

ShanaLMoore opened this issue Feb 13, 2024 · 2 comments
Assignees
@ShanaLMoore
Labels
bug something isn't working Knapsack Upgrade

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Feb 13, 2024 •
edited
Loading

Story

ref: #307
Another piece of weird styling revealed itself today. A collection homepage is showing the title in white font on a white background with raised text shadows. Usually, Hyku only shows me this view if I try to upload a banner to a collection page (and I never do that because the feature breaks collections so they can't be edited).

First screenshot below shows a Knapsack collection with weird homepage styling. Second screenshot shows the expected font look on a collection homepage with no banner image.

Image

Image

https://demo.adventist-knapsack-staging.notch8.cloud/collections/66de37df-a236-4a1f-a48b-8dbe145e7c46?locale=en

Acceptance Criteria

  • feature parity with ADL production

ADL PROD:
image

Notes
@ShanaLMoore ShanaLMoore added bug something isn't working Knapsack Upgrade labels Feb 13, 2024
@ShanaLMoore ShanaLMoore mentioned this issue Feb 13, 2024
Closed
@ShanaLMoore ShanaLMoore self-assigned this Feb 13, 2024
ShanaLMoore referenced this issue Feb 13, 2024
@ShanaLMoore
Update adl-overrides.scss
0a043d0 
Collection show page text appears white with a text-shadow. The client wants feature parity with production, which is dark colored text and no text-shadow.

Issue:
- https://github.com/scientist-softserv/adventist-dl/issues/724
@ShanaLMoore ShanaLMoore mentioned this issue Feb 13, 2024
Merged
ShanaLMoore referenced this issue Feb 14, 2024
@ShanaLMoore
🧹 i724 - Update styling for collection show page (#116)
6febd30 
Collection show page text appears white with a text-shadow. The client
wants feature parity with production, which is dark colored text and no
text-shadow.

Issue:
- https://github.com/scientist-softserv/adventist-dl/issues/724



# Expected Behavior Before Changes

![Screenshot 2024-02-13 at 12-14-12 Random folder of cool stuff __
Hyku](https://github.com/scientist-softserv/adventist_knapsack/assets/10081604/c0b4ee5b-1c6c-46a1-bc08-29774e5bcdba)

# Expected Behavior After Changes
![Screenshot 2024-02-13 at 12-14-25 collection test __
Hyku](https://github.com/scientist-softserv/adventist_knapsack/assets/10081604/9f789872-b08f-4252-9217-9e5f6e339425)
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Feb 14, 2024 •
edited
Loading

QA Results: Pass ✅

Tested on: DEMO - Staging
Collection title is no longer white with a shadow, and matches adventist production's style.

Image

@KatharineV
Copy link

Agreed. ADL QA finds that collection names no longer show as white on white text, and the drop shadow is gone.

@kirkkwang kirkkwang transferred this issue from scientist-softserv/adventist-dl May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShanaLMoore ShanaLMoore

Labels
bug something isn't working Knapsack Upgrade
Projects
adventist-dl
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShanaLMoore @KatharineV