Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should the gem auto create app/views/hyrax/base/iiif_viewers or is that an app concern? #28

Closed
3 tasks
Tracked by #19
kirkkwang opened this issue Dec 14, 2022 · 2 comments · Fixed by #68
Closed
3 tasks
Tracked by #19
Assignees

Comments

@kirkkwang
Copy link
Contributor

kirkkwang commented Dec 14, 2022

Summary

Acceptance Criteria

  • The application that IIIF Print is installed on should have the Hyrax 3+ implementation of universal viewer

Screenshots or Video

Testing Instructions

  • navigate to a work show page that has an image
  • confirm Universal Viewer loads

Notes

Confused how to fill this out? Check out the playbook

@kirkkwang
Copy link
Contributor Author

kirkkwang commented Dec 19, 2022

need, should be a concern of the gem

view partial override should live in the gem, should not be apart of generator

did the view partial change in hyrax 3? 4?

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Dec 19, 2022

put the view partial in the gem (combo of lv and hyrax)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants