Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: verify that running the generators gets you all the needed adjustments for iiif search found in lousiville app/controller/catalog_controller.rb #33

Closed
Tracked by #19
kirkkwang opened this issue Dec 14, 2022 · 2 comments

Comments

@kirkkwang
Copy link
Contributor

kirkkwang commented Dec 14, 2022

Summary

verify that running the generators gets you all the needed adjustments for iiif search found in lousiville app/controller/catalog_controller.rb

Acceptance Criteria

  • [ ]

Screenshots or Video

Testing Instructions

Notes

Implementation suggestion:

run the generator from iiif print main on a clean hyku and then compare the CatalogController of each spot and take note of the diff.

@ShanaLMoore ShanaLMoore changed the title verify that running the generators gets you all the needed adjustments for iiif search found in lousiville app/controller/catalog_controller.rb Spike: verify that running the generators gets you all the needed adjustments for iiif search found in lousiville app/controller/catalog_controller.rb Jan 20, 2023
@kirkkwang
Copy link
Contributor Author

i ran the generator and saw a lot of tiny differences that didn’t seem like it was noteworthy, but this one stuck out to me, https://github.com/scientist-softserv/louisville-hyku/blob/main/app/controllers/catalog_controller.rb#L484-L503
this whole method is missing from the generator, does it look like something we want?

@jillpe
Copy link

jillpe commented Feb 2, 2023

closed - confirmed by @laritakr we can combine this with #40

@jillpe jillpe closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

No branches or pull requests

2 participants