Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconcile iiif_manifest_presenter.rb with Hyku's iiif_manifest_presenter_decorator.rb. do not do both a decorator and a full override #35

Closed
Tracked by #19
kirkkwang opened this issue Dec 14, 2022 · 0 comments · Fixed by #70
Assignees

Comments

@kirkkwang
Copy link
Contributor

kirkkwang commented Dec 14, 2022

ref #62

Summary

ref LV: https://github.com/scientist-softserv/louisville-hyku/blob/42a0fc837fd9ef4832a9741731672200e0097305/app/presenters/hyrax/iiif_manifest_presenter.rb

ref HYKU: https://github.com/samvera/hyku/blob/main/app/presenters/hyrax/iiif_manifest_presenter_decorator.rb

Compare the differences between these two files and decide which one we should take.

We also may also need to take account the difference between Hyrax and Hyku. Site.account is hyku specific since Hyrax doesn't have concept of tenants.

Acceptance Criteria

  • [ ]

Screenshots or Video

Testing Instructions

Notes

Confused how to fill this out? Check out the playbook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant