Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply fix from app/services/newspaper_works/data/work_files_decorator to the iiif_print gem #38

Closed
Tracked by #19
kirkkwang opened this issue Dec 14, 2022 · 3 comments
Assignees

Comments

@kirkkwang
Copy link
Contributor

kirkkwang commented Dec 14, 2022

ref LV: https://github.com/scientist-softserv/louisville-hyku/blob/main/app/services/newspaper_works/data/work_files_decorator.rb

compare to iiif_print: https://github.com/scientist-softserv/iiif_print/search?q=commit_assigned

redefine method in iiif_print to match LV

@ShanaLMoore
Copy link
Contributor

TODO: Trace down the commit of the project that pulled this fix in, to try to figure out what this fixed. please take notes on findings.

@ShanaLMoore ShanaLMoore self-assigned this Jan 17, 2023
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jan 17, 2023

TODO: Trace down the commit of the project that pulled this fix in, to try to figure out what this fixed. please take notes on findings.

LV: https://github.com/scientist-softserv/louisville-hyku/blob/42a0fc837fd9ef4832a9741731672200e0097305/app/services/newspaper_works/data/work_files_decorator.rb
comment states: Overrides newspaper_works 1.0.1 to allow update or create based on work state

Which originally came from NNP: per this PR.

corresponding gitlab MR:

its MR message says:

I believe this work steps on the existing ocr reading, but I also believe the new implementation is better, as it has in document coordenants and doesn't seem to have downsides. I did not fully remove the other ocr code at this point, but we may want to.
We added the fairly great newspaper_works gem to get a lot of these functions. However, the newspaper_works gem is kind of an all in one thing so it brought over other items we did not need. We removed the newspaper work types. We kept the saved search, advanced search and search history things, but we have not configured them.
Please pay special attention to the config/initializers/patch_blacklight_advanced_search.rb

commit says:

Set up OCR per file, in viewer search and creates derivatives PDFs if images are uploaded.

@kirkkwang
Copy link
Contributor Author

There are specs to test the paths of this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

No branches or pull requests

2 participants