Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Progressive upgrade if versions skipped #777

Closed
2 tasks done
Emojigit opened this issue Apr 27, 2024 · 2 comments
Closed
2 tasks done

[Feature] Progressive upgrade if versions skipped #777

Emojigit opened this issue Apr 27, 2024 · 2 comments

Comments

@Emojigit
Copy link

Checklist

  • I have already read docs/Tips.md, but my feature is not implemented.
  • My suggested feature was not mentioned by others, and it is not a duplicate feature.

Summary

The differential packages of HoYoverse games (in my case, Genshin Impact) upgrade the game by modifying the files in the previous version. This approach is optimal for most players as it reduces the size of the data downloaded.

However, for players skipping (one or more) versions, the current approach may not be optimal in terms of disk usage. Starward and the official launcher (IIRC) download all the differential packages at once but still apply them one by one due to their technical nature. During an iteration, differential packages not used in this iteration are redundant, yet still span up disk spaces, resulting in extra disk usage.

Solution or Design

Updates can be handled step-by-step: download the differential package of the version after the installed one, apply its patch, delete the package, and then repeat these steps for the next version. This will be useful for players having a disk space shortage, especially if the available space is a few GBs larger than the required size.

@Emojigit Emojigit added the triage Issue needs to be triaged label Apr 27, 2024
@Scighost
Copy link
Owner

Your suggestion is very good, but in fact it is not feasible. The latest version is 4.6, and the versions that can be updated through differential packages are 4.4 and 4.5. If a player's local game version is 4.3, I have no way to get the differential packages from 4.3 to 4.4 or 4.5.

@Scighost Scighost added Area: Install Game and removed triage Issue needs to be triaged labels Apr 28, 2024
@starward-bot
Copy link

starward-bot bot commented May 13, 2024

This issue will be closed due to no reply for more than 14 days.

@starward-bot starward-bot bot closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants