Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start angle for motion-based panoramas #26

Merged
merged 2 commits into from May 26, 2018
Merged

Conversation

Sega-Zero
Copy link
Contributor

This PR provides ability to specify start angle for motion based panoramas as well as touch based.
I also would like to apply start angle to sphere panoramas too, but couldn't figure out where should I apply it.

@scihant scihant merged commit cfe6eb9 into scihant:dev May 26, 2018
@scihant
Copy link
Owner

scihant commented May 26, 2018

Thanks for the PR. Applying the starting angle in the spherical case is much harder because you need to calculate a new quaternion that has only one of its axes modified.

I'm merging this one for now but I think that modifying the texture coordinates of the geometry could be a better solution for this because it could work both in cylindrical and spherical cases. I'll experiment with the idea when I find the time. Feel free to try it yourself to see whether it would work.

@Sega-Zero
Copy link
Contributor Author

I was hoping the same y-axis patch will work (and it's actually what I really need now), but couldn't get it working :) Unfortunately, I don't have enough knowledge in this area, so I would be very appreciated of you point me to the right direction :)
I need to start a panorama at specified y-axis location and then rotate it when user moves a phone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants