Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with ops.equals #6

Open
ghost opened this issue May 9, 2015 · 0 comments
Open

Problems with ops.equals #6

ghost opened this issue May 9, 2015 · 0 comments

Comments

@ghost
Copy link

ghost commented May 9, 2015

I have been encountering various problems with ops.equals when running tests for my own ndarray modules.

Different lengths seem to play a role. I wrote the following test and it fails:

var x2 = ndarray(new Float32Array([0]));
var y2 = ndarray(new Float32Array([0, 1]));
t.assert(!ops.equals(x2, y2))

Maybe this is outside the intended use case and you only intended that ndarrays with the same length and same underlying buffer format get compared. Nevertheless, having more robust falsiness behavior would make it easier to instrument and test modules.

I think there are other things. I will update this issue as I find them. I will also try to fix them.

UPDATE:
I am just going to implement my own equals method, since that would be faster/easier for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants