Bundle "ninja_syntax.py" into the wheel #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, please merge before you upload the PyPI package. |
|
@Maratyszcza Will do. And will make sure the CI is green before doing so. Note also that the next version of the package will be |
jcfr
force-pushed
the
add-ninja_syntax
branch
from
df0f7d0
to
d5f9cf0
Compare
To maintain backward compatibility with existing ninja wheels, this commit includes "ninja_syntax.py". Suggested-by: Marat Dukhan <maratek@gmail.com>
jcfr
force-pushed
the
add-ninja_syntax
branch
from
d5f9cf0
to
147e5df
Compare
Current coverage is 86.36% (diff: 83.33%)@@ master #1 diff @@
==========================================
Files 1 1
Lines 16 22 +6
Methods 0 0
Messages 0 0
Branches 2 3 +1
==========================================
+ Hits 14 19 +5
Misses 0 0
- Partials 2 3 +1
|
|
Since Appveyor, CircleCI and Travis were green. Topic was integrated as ee84aed The CI looks red only because codecov complains |
|
Tag for 1.7.2 has been pushed https://github.com/scikit-build/ninja-python-distributions/releases/tag/1.7.2 |
|
Associate packages will be uploaded as soon Appveyor, CircleCI and Travis are done generating them. |
|
Et voila, see https://pypi.python.org/pypi/ninja/1.7.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To maintain backward compatibility with existing ninja wheels, this
commit includes "ninja_syntax.py".
Suggested-by: Marat Dukhan maratek@gmail.com