-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify setting cmake-preset #204
Comments
You can do You can't detect extras, those are only for dependencies and are not passed through the built system. |
Holy smokes that worked. I've enabled the coverage build and changed the build directory and I managed to get test coverage across the python api. Thanks! |
So to summarize on what would be nice to have here:
|
What do you mean by "directly"? I'm not sure how it can be more "direct". The next version of Pip will support CMake preset can currently only be passed via |
"directly" as in just passing |
That would then be an option to Pip instead of us? |
Oh, I remember some implementation with |
The best I could properly do would be [tool.scikit-build.cmake.define]
SOME_OPTION=true
# vs
[tool.scikit-build.D]
SOME_OPTION=true |
PEP 517 handles all configuration though the config-settings object that's passed to the build hook. You can't just pass arbitrary things around - and it never worked very well with setup.py, as calling that directly is discouraged and somewhat broken, and getting those things passed through pip was not pretty (I remember lots of |
Hmm, if it is not possible, I think the current method is preferred. Just having |
I'm thinking if we can pass conditional cmake flags based on the optional dependencies or other parameter that we can pass to
pip install .
.This came up when thinking about how to code-coverage a python-C binding. If we build with the
--coverage
flags, then in principle we should be able to trigger those duringpytest
and resolve the information withlcov
. But we also don't want to ship it with those flags on. So any advice on how to design this?Also related, being able to configure via cmake-preset?
The text was updated successfully, but these errors were encountered: