Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NetBSD support #971

Closed
moubctez opened this issue May 5, 2023 · 0 comments · Fixed by #977
Closed

Add NetBSD support #971

moubctez opened this issue May 5, 2023 · 0 comments · Fixed by #977

Comments

@moubctez
Copy link

moubctez commented May 5, 2023

scikit-build works well on NetBSD, so it should be enabled

--- skbuild/platform_specifics/platform_factory.py.orig	2023-05-05 18:58:16.000000000 +0000
+++ skbuild/platform_specifics/platform_factory.py
@@ -34,7 +34,7 @@ def get_platform() -> abstract.CMakePlat
 
         return osx.OSXPlatform()
 
-    if this_platform in {"freebsd", "os400", "openbsd"}:
+    if this_platform in {"freebsd", "netbsd", "os400", "openbsd"}:
         from . import bsd
 
         return bsd.BSDPlatform()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add support for netbsd & pyodide (future) scikit-build/scikit-build
1 participant
@moubctez