New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency fix #89
Dependency fix #89
Conversation
Is there a chance we can land this? I'm happy to review if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making it work again! Really appreciate it!
@MechCoder It will be great if this PR could be merged! |
Hello, rfqr = RandomForestQuantileRegressor(random_state=0) File "", line 1, in File "C:\Users\HerrSiqueira\anaconda3\envs\mestrado\lib\site-packages\skgarden\quantile\ensemble.py", line 295, in init File "C:\Users\HerrSiqueira\anaconda3\envs\mestrado\lib\site-packages\skgarden\quantile\tree.py", line 222, in init TypeError: super(type, obj): obj must be an instance or subtype of type |
Updated the imports to their current versions. Specifically:
sklearn.externals.joblib
is replaced withjoblib
sklearn.utils.testing
is replaced withnumpy.testing
sklearn.externals.six
is replaced withsix
sklearn.tree.tree
is replaced withsklearn.tree
presort
parameter removed from calls toDecisionTreeRegressor
assert_true
,assert_false
,assert_greater
andassert_less
with their equivalentassert
statementsForestClassifier
andForestRegressor
can't be imported fromsklearn
anymore, the source code for these are now placed inforest.py
All unit tests in
tests/
,mondrian/tree/tests/
,mondrian/ensemble/tests
andquantile/tests
run with no errors.