Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency fix #89

Merged
merged 8 commits into from Jun 22, 2021
Merged

Conversation

saattrupdan
Copy link
Contributor

@saattrupdan saattrupdan commented Mar 18, 2020

Updated the imports to their current versions. Specifically:

  1. sklearn.externals.joblib is replaced with joblib
  2. sklearn.utils.testing is replaced with numpy.testing
  3. sklearn.externals.six is replaced with six
  4. sklearn.tree.tree is replaced with sklearn.tree
  5. presort parameter removed from calls to DecisionTreeRegressor
  6. Replaced occurences of assert_true, assert_false, assert_greater and assert_less with their equivalent assert statements
  7. As ForestClassifier and ForestRegressor can't be imported from sklearn anymore, the source code for these are now placed in forest.py

All unit tests in tests/, mondrian/tree/tests/, mondrian/ensemble/tests and quantile/tests run with no errors.

@Bougeant
Copy link

Is there a chance we can land this? I'm happy to review if needed.

Copy link

@Bougeant Bougeant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making it work again! Really appreciate it!

@PSSF23
Copy link

PSSF23 commented Jun 22, 2021

@MechCoder It will be great if this PR could be merged!

@MechCoder MechCoder merged commit b9c5d84 into scikit-garden:master Jun 22, 2021
@lnpsiqueira
Copy link

Hello,
Did anybody got this error?

rfqr = RandomForestQuantileRegressor(random_state=0)
Traceback (most recent call last):

File "", line 1, in
rfqr = RandomForestQuantileRegressor(random_state=0)

File "C:\Users\HerrSiqueira\anaconda3\envs\mestrado\lib\site-packages\skgarden\quantile\ensemble.py", line 295, in init
base_estimator=DecisionTreeQuantileRegressor(),

File "C:\Users\HerrSiqueira\anaconda3\envs\mestrado\lib\site-packages\skgarden\quantile\tree.py", line 222, in init
super(DecisionTreeQuantileRegressor, self).init(

TypeError: super(type, obj): obj must be an instance or subtype of type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants