Skip to content
This repository has been archived by the owner on Oct 25, 2022. It is now read-only.

CONTRIBUTING.md #30

Closed
LovelyBuggies opened this issue Mar 28, 2020 · 2 comments
Closed

CONTRIBUTING.md #30

LovelyBuggies opened this issue Mar 28, 2020 · 2 comments

Comments

@LovelyBuggies
Copy link
Collaborator

LovelyBuggies commented Mar 28, 2020

Considering that aghast is under heavy development, I think it would be nice to add something like CONTRIBUTING.md to involve others in.

Maybe split manual installation from README to CONTRIBUTING. I'll work on it and pull you a request after finishing. 😊

@jpivarski
Copy link
Member

I do need to learn about how to set up a CONTRIBUTING.md (like, I need to read a few examples to see what they're like), but Aghast is not in active development. The last commit was July 8, 2019. I intend to cycle back to it when other responsibilities are settled, so it's nor orphaned, but it is being left on its own for a while.

For the correction you need to make, finding out what's wrong with "sumw2", you don't need to do any extensive work, just put some print statements into the function that's supposed to deliver the dict with "sumw2" and trace back to find out where it went.

@LovelyBuggies
Copy link
Collaborator Author

LovelyBuggies commented Mar 28, 2020

you don't need to do any extensive work

Ok.

finding out what's wrong with "sumw2"

Don't worry! I have seen some potential dangerous, e.g. no manipulation when sumw2 == None and all tests are loaded from ROOT cls.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants