New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the tests that are currently skipped due to setidentity segfaults. #133
Conversation
…ed C-style assertions that were wrong. C-style assertions don't provide useful output in Python, so they've been converted into RuntimeErrors.
So it wasn't really the Identities themselves, just the assertions (see comment above). The reason I've never hit this before is that I'm only now compiling in Debug mode (to get faster recompilations). Most of the assertions were added early in the project and weren't tested. These were "wrong" in that they had off-by-one errors in their allowed range—an easy mistake to make. Now all the tests are in and we're back to the level of testing we had before the change in build procedure (a little over 2000 assertions). I'll merge this as soon as the tests are green. |
Also, this was a first test-run of the new localbuild.py script. It's a fantastic debugging workflow! |
…ill a good hint of something general).
It was a mistake I had previously fixed for non-tuple RecordArrays, and it was right next to my mistake for the tuple RecordArrays. It would not have been fixed by transitioning Good catch, Windows! |
Maybe the easiest way to fix them is to make them immutable.
After that,
parameters
will be the only non-immutable part of an array, so that would go next to make them purely immutable.