Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ refactoring: Highlevel non-reducers and improved testing/fixes for reducers. #1206

Merged
merged 8 commits into from Jan 7, 2022

Conversation

jpivarski
Copy link
Member

@jpivarski jpivarski commented Jan 6, 2022

Tests that still need to be converted to v2:

  • test_0889-ptp.py
  • test_0982-missing-case-in-nonlocal-reducers.py
  • test_0992-correct-ptp-unmasking.py
  • test_1000-fixes-argmax-for-ListOffsetArray-with-nonzero-start.py
  • test_1071-mask-identity-false-should-not-return-option-type.py
  • test_1106-argminmax-axis-None-missing-values.py

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #1206 (b3f563c) into main (1751ffc) will increase coverage by 0.35%.
The diff coverage is 77.00%.

Impacted Files Coverage Δ
src/awkward/_v2/_broadcasting.py 90.59% <ø> (ø)
.../awkward/_v2/operations/structure/ak_singletons.py 80.00% <ø> (ø)
src/awkward/_v2/operations/convert/ak_to_list.py 50.00% <42.30%> (-30.00%) ⬇️
src/awkward/_v2/highlevel.py 64.99% <66.66%> (+0.21%) ⬆️
src/awkward/_v2/operations/reducers/ak_mean.py 78.57% <70.00%> (-1.43%) ⬇️
src/awkward/_v2/operations/reducers/ak_moment.py 78.57% <70.00%> (-1.43%) ⬇️
src/awkward/_v2/operations/convert/ak_to_numpy.py 88.88% <75.00%> (-11.12%) ⬇️
src/awkward/_v2/operations/reducers/ak_covar.py 82.35% <76.92%> (+2.35%) ⬆️
src/awkward/_v2/operations/reducers/ak_var.py 82.35% <76.92%> (+2.35%) ⬆️
src/awkward/_v2/operations/reducers/ak_corr.py 81.81% <77.77%> (+1.81%) ⬆️
... and 22 more

@jpivarski jpivarski enabled auto-merge (squash) January 7, 2022 16:57
@jpivarski jpivarski merged commit 88fd323 into main Jan 7, 2022
@jpivarski jpivarski deleted the jpivarski/highlevel-non-reducers branch January 7, 2022 17:15
@jpivarski jpivarski changed the title Highlevel non-reducers and improved testing/fixes for reducers. C++ refactoring: Highlevel non-reducers and improved testing/fixes for reducers. Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant