C++ refactoring: ak.nan_to_num #1352

ioanaif · 2022-03-08T14:02:37Z

No description provided.

for more information, see https://pre-commit.ci

codecov · 2022-03-08T14:42:44Z

Codecov Report

Merging #1352 (290c830) into main (b2fd2be) will increase coverage by 0.40%.
The diff coverage is 52.17%.

Impacted Files	Coverage Δ
src/awkward/_v2/_connect/cling.py	`0.00% <0.00%> (ø)`
src/awkward/_v2/_connect/pyarrow.py	`85.74% <0.00%> (ø)`
src/awkward/_v2/_lookup.py	`97.50% <0.00%> (ø)`
src/awkward/_v2/_prettyprint.py	`66.09% <0.00%> (+2.29%)`	⬆️
src/awkward/_v2/_typetracer.py	`69.14% <0.00%> (ø)`
src/awkward/_v2/behaviors/string.py	`90.00% <ø> (ø)`
src/awkward/_v2/forms/bitmaskedform.py	`78.04% <0.00%> (ø)`
src/awkward/_v2/forms/bytemaskedform.py	`77.33% <0.00%> (ø)`
src/awkward/_v2/forms/emptyform.py	`79.62% <0.00%> (-0.38%)`	⬇️
src/awkward/_v2/forms/form.py	`90.06% <0.00%> (ø)`
... and 133 more

jpivarski

Great, it's using the new _impl and everything! It looks good to me (and the v1 implementation is still in recent memory), so I'll merge it.

ioanaif and others added 2 commits March 8, 2022 15:59

ak.nan_to_num and testing

ccb4299

[pre-commit.ci] auto fixes from pre-commit.com hooks

290c830

for more information, see https://pre-commit.ci

ioanaif requested a review from jpivarski March 8, 2022 15:25

jpivarski approved these changes Mar 8, 2022

View reviewed changes

jpivarski merged commit 7f5a250 into main Mar 8, 2022

jpivarski deleted the ioanaif/ak.nan_to_num branch March 8, 2022 15:46