New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revised getitem operation for masked jagged indexers #322
Conversation
First pass, some new kernels will need to be made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I just have a lot of little comments.
I think the functionality is there now. I think the boilerplate for kernels is pretty out of hand, would be nice to find a way to reduce it. Remaining items:
|
We don't have a tool for that; I did it by hand. If it's roughly or mostly 80 characters, that is fine.
Merge upstream master; it was fixed today (PR #323). |
I'm going to merge your branch with master, which should fix the doctest. After that, it's done, right? You're not planning any more changes? |
We're going to ignore the doctest error; I'll ask Reik to look into that after all the merges are done. Assuming all the other tests pass, should I merge this? I'm dealing with the compiler warnings on another PR. |
Ok, now that its formatted and docs are added, I think its ready |
Closes #315 |
First pass, some new kernels will need to be made.