Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add pass_apply argument to util #918

Merged
merged 1 commit into from Jun 14, 2021
Merged

Feature: add pass_apply argument to util #918

merged 1 commit into from Jun 14, 2021

Conversation

agoose77
Copy link
Collaborator

This is a very simple PR to add pass_apply to recursively_apply. This permits clients of this function to re-enter, without re-implementing the same logic. This is not useful for #912 but is useful for #917

jpivarski
jpivarski approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very simple and won't break any existing code. I'll enable auto-merge so that you can start using it as soon as the tests pass.

@jpivarski jpivarski enabled auto-merge (squash) June 14, 2021 16:00
@jpivarski jpivarski merged commit 00b1263 into main Jun 14, 2021
@jpivarski jpivarski deleted the feature-add-pass-apply-to-recursively-apply branch June 14, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agoose77 @jpivarski