Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ak._v2 missing size #1553

Closed
agoose77 opened this issue Jul 19, 2022 · 3 comments
Closed

ak._v2 missing size #1553

agoose77 opened this issue Jul 19, 2022 · 3 comments
Labels
bug The problem described is something that must be fixed good first issue Good for newcomers

Comments

@agoose77
Copy link
Collaborator

Version of Awkward Array

HEAD

Description and code to reproduce

v1 implements ak.size but we have not ported it over to v2.
@agoose77 agoose77 added bug (unverified) The problem described would be a bug, but needs to be triaged bug The problem described is something that must be fixed good first issue Good for newcomers and removed bug (unverified) The problem described would be a bug, but needs to be triaged labels Jul 19, 2022
@agoose77 agoose77 added this to To-do: easy in Prioritized issues Jul 19, 2022
@jpivarski
Copy link
Member

That was intentional. Let me get back to this.

@jpivarski
Copy link
Member

Actually, np.size isn't even part of the NumPy API. NumPy arrays have a size property, but this would be meaningless for an Awkward Array. The v1 ak.size was to satisfy Pandas, a feature we gave up on in #350.

So this function should not be reimplemented in v2. We're taking advantage of the chance to change the API with a major release boundary.

See also discussion on https://gitter.im/Scikit-HEP/awkward-array at around this date: 2022-07-19 at 10:14am CDT.

Prioritized issues automation moved this from To-do: easy to Done Jul 19, 2022
@jpivarski jpivarski removed this from Done in Prioritized issues Jul 19, 2022
@agoose77
Copy link
Collaborator Author

Wait, you're right! 🤦. I'm pretty sure I've made this exact assumption before. Apologies for the noise everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The problem described is something that must be fixed good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agoose77 @jpivarski