Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename src/histogram/accumulators.cpp to src/register_accumulators.cpp etc #101

Closed
HDembinski opened this issue Sep 16, 2019 · 3 comments · Fixed by #105
Closed

Rename src/histogram/accumulators.cpp to src/register_accumulators.cpp etc #101

HDembinski opened this issue Sep 16, 2019 · 3 comments · Fixed by #105
Milestone

Comments

@HDembinski
Copy link
Member

It is generally a good idea to call a file after the class or function if the file only includes a single class or function. For me it would be much more logical to rename accumulators and the other implementation files to register_something so it matches the functions in these files.

@HDembinski HDembinski changed the title Rename src/histogram/accumulators.cpp to src/register_accumulators.cpp Rename src/histogram/accumulators.cpp to src/register_accumulators.cpp etc Sep 16, 2019
@HDembinski
Copy link
Member Author

It would make it easier to navigate to the right file in Atom, for example.

@henryiii
Copy link
Member

henryiii commented Sep 16, 2019

Sure, the names of these files are not something I necessarily thought much about and should be clear/consistent.

@henryiii henryiii added this to the 0.50 milestone Sep 16, 2019
@henryiii
Copy link
Member

henryiii commented Sep 16, 2019

(Technically this is an "enhancement", and not a 0.50 milestone requirement, as it doesn't change the API, but it's easy and I'd like it done sooner rather than later.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants