-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure pipenv-based development workflow works #116
Comments
hm -- maybe this is an issue with my local installation since that's exactly what we do in travis. |
Hm, this seems odd as |
We can also see from Travis Build 366 that the benchmarks are getting run when a PR is merged into |
@matthewfeickert I think the issue might be that we manually upgrade pytest in the travis file. If we need a specific version probably concretely what happens for me is that with pipenv
it still picks up a pytest outside of the pipenv, and that pytest wil not be able to import dependencies installed in the virtualenv |
pip install -e .[develop]
Ah okay. Sorry, I haven't been using pipenv so I haven't noticed this. Let me setup a new environment with it and see what is the minimum package versions to make things work. |
closing this can't even reproduce this locally :-p |
Ah okay, so all is working well then? |
Description
We support a number of extras like the various tensorbackends, but as far as I know none of them are mutually exclusive and all of them are needed for running the unit tests.
We should therefore make sure
pip install -e[develop]
installs all necessary packages to run the tests. I think also pytest-benchmark is missing (@kratsg mentioned that)The text was updated successfully, but these errors were encountered: