Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should pyhf detect and handle multiple modifiers with the same type/name? #1899

Open
1 task done
kratsg opened this issue Jun 28, 2022 · 1 comment
Open
1 task done

Should pyhf detect and handle multiple modifiers with the same type/name? #1899

kratsg opened this issue Jun 28, 2022 · 1 comment
Labels
feat/enhancement New feature or request needs-triage Needs a maintainer to categorize and assign question Further information is requested

Comments

@kratsg
Copy link
Contributor

kratsg commented Jun 28, 2022 •
edited

Summary

Unlike correlating modifiers (e.g. histosys and normsys) - when we have modifiers of a given type (e.g. normsys) with the same name added to a particular sample, only the last one is being picked up and used in the model with no warning from pyhf. Should we catch this?

Related: #1830.

Additional Information

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@kratsg kratsg added feat/enhancement New feature or request question Further information is requested needs-triage Needs a maintainer to categorize and assign labels Jun 28, 2022
@matthewfeickert
Copy link
Member

Oh yeah that seems like a bug if we aren't very loudly warning. I would be +1 on adding this.

@alexander-held alexander-held mentioned this issue Aug 28, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat/enhancement New feature or request needs-triage Needs a maintainer to categorize and assign question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kratsg @matthewfeickert