Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old GHA choice input by type: boolean #1966

Closed
Sinclert opened this issue Aug 27, 2022 · 1 comment · Fixed by #2480
Closed

Replace old GHA choice input by type: boolean #1966

Sinclert opened this issue Aug 27, 2022 · 1 comment · Fixed by #2480
Labels
chore Other changes that don't modify src or test files CI CI systems, GitHub Actions

Comments

@Sinclert
Copy link

This issue started as an informal conversation between @matthewfeickert and myself on Twitter.

If I am not mistaken, GitHub recently extended the possible values for the type field, when describing workflow parameters. Possible values for this field are: string, choice, environment and boolean (this is the blog post where the list was extended).

Therefore, any choice marked input, whose only options are true and false, can be simplified by stating type: boolean. I personally did this in a couple of projects, and this is how it looks like:

Screenshot 2022-08-27 at 17 13 10


I suggest you simplify the syntax of the following workflows:

@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions chore Other changes that don't modify src or test files labels Aug 28, 2022
@matthewfeickert matthewfeickert added this to To do in v0.7.0 via automation Aug 28, 2022
@matthewfeickert matthewfeickert removed this from To do in v0.7.0 Aug 28, 2022
@matthewfeickert matthewfeickert added this to To do in v0.7.1 via automation Aug 28, 2022
@matthewfeickert matthewfeickert removed this from To do in v0.7.1 Apr 7, 2023
@matthewfeickert
Copy link
Member

Resolved by PR #2480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files CI CI systems, GitHub Actions
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

2 participants