fix: dask failing for TTrees with duplicate TBranch names #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpivarski
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
This only changes an internal interface, and even if Coffea is relying on this internal interface, it only adds a new keyword argument at the end of an argument list, whose default value is no change in behavior. It's completely safe.
Moreover, it ought to solve the problem of duplicates in uproot.dask, and the test demonstrate it.
I'll merge this PR after committing my one suggestion below.
nsmith-
added a commit
to nsmith-/uproot5
that referenced
this pull request
Apr 17, 2024
…ikit-hep#1189)" This reverts commit f137305.
jpivarski
added a commit
that referenced
this pull request
May 7, 2024
jpivarski
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.