Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theoretical_description_classification.rst #215

Merged
merged 1 commit into from Aug 22, 2022
Merged

Update theoretical_description_classification.rst #215

merged 1 commit into from Aug 22, 2022

Conversation

AndreaPi
Copy link
Contributor

@AndreaPi AndreaPi commented Aug 3, 2022

Description

This PR fixes an error in the documentation. Assuming the scores are ranked from highest to lowest until the conformity score of the true label is found, then the true label Yᵢ should be equal to πₖ (the last label to be included), not πⱼ. j is a running index, so Yᵢ cannot be equal to πⱼ for all j from 1 to k.

Type of change

  • This change requires a documentation update

Checklist

Assuming the scores are ranked from highest to lowest until the conformity score of the true label is found, then the true label Yᵢ should be equal to  πₖ (the last label to be included), not πⱼ. j is a running index, so  Yᵢ  cannot be equal to πⱼ for all j from 1 to k.
@AndreaPi
Copy link
Contributor Author

Any news on this PR? @vtaquet @LacombeLouis @gmartinonQM ?

@vtaquet
Copy link
Member

vtaquet commented Aug 19, 2022 via email

Copy link
Member

@vtaquet vtaquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AndreaPi , thanks for spotting the typo ! You're right, and your modification is valid.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (726e731) compared to base (e56f709).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         2188      2188           
  Branches       241       241           
=========================================
  Hits          2188      2188           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vtaquet vtaquet merged commit 8e36db4 into scikit-learn-contrib:master Aug 22, 2022
@AndreaPi AndreaPi deleted the patch-2 branch August 23, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants