Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ensembled predictions even when alpha is None #252

Open
gmartinonQM opened this issue Jan 5, 2023 · 0 comments
Open

Return ensembled predictions even when alpha is None #252

gmartinonQM opened this issue Jan 5, 2023 · 0 comments
Assignees
Labels
developers Proposed by developers. enhancement New feature or request

Comments

@gmartinonQM
Copy link
Contributor

Hi all, and thanks you so much for developping MAPIE !

I recently hit a limitation of MapieRegressor and MapieTimeSeriesRegressor : I would like to get the ensembled predictions (using the ensemble=True argument in .predict()), but without computing any confidence interval. So I used alpha=None, but in this case, the ensemble argument is ignored, since the code returns immediately the single_estimator_ predictions.

However, it might be that we still want to extract the ensembled prediction (which is easily available in MAPIE class internals) even when alpha=None, given that the computation of this prediction is rather involved.

So it appears that there is an unnecessary coupling between alpha=None and the ability to retrieve ensembled predictions.

Would it be possible to decouple these two quite different things ?

@gmartinonQM gmartinonQM added the enhancement New feature or request label Jan 5, 2023
@LacombeLouis LacombeLouis linked a pull request Jan 17, 2023 that will close this issue
7 tasks
@LacombeLouis LacombeLouis removed a link to a pull request Jan 18, 2023
7 tasks
@LacombeLouis LacombeLouis linked a pull request Jan 18, 2023 that will close this issue
7 tasks
@LacombeLouis LacombeLouis added this to Methods to be implemented (Short Term) in Developments via automation Feb 23, 2023
@LacombeLouis LacombeLouis moved this from Methods to be implemented (Short Term) to Bugs to be fixed (Short Term) in Developments Feb 23, 2023
@thibaultcordier thibaultcordier removed this from Bugs to be fixed (Short Term) in Developments Feb 23, 2023
@thibaultcordier thibaultcordier added this to Need triage in Developments via automation Feb 23, 2023
@thibaultcordier thibaultcordier moved this from Need triage to Bugs to be fixed (Short Term) in Developments Feb 23, 2023
@thibaultcordier thibaultcordier added the developers Proposed by developers. label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developers Proposed by developers. enhancement New feature or request
Projects
Developments
Bugs to be fixed (High Priority)
Development

Successfully merging a pull request may close this issue.

4 participants