New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First instance of mapie classifier #79
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #79 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 9 11 +2
Lines 554 811 +257
Branches 42 54 +12
==========================================
+ Hits 554 811 +257
Continue to review full report at Codecov.
|
Beau boulot pour l'initiation de
|
J'ai pris en compte les différents commentaires. Il reste à regrouper les fonctions identiques de mapieclassifier et mapieregression dans utils. |
J'ai regroupé les fonctions identiques dans utils. |
mapie/classification.py
Outdated
cv: Optional[str] | ||
The cross-validation strategy for computing scores : | ||
|
||
- ``None``, to use mapie for fitting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Décris un peu plus explicitement ce que ça va faire : "None
, MapieClassifier
will be used for fitting the base model" ou quelque chose comme ça.
Description
First instance of mapie classifier with the fit and predict methods, the corresponding checks and the test file.
Type of change
Please check options that are relevant.
How Has This Been Tested?
The tests are carried out on the classification.py module with test_classification.py (see file for more details)
Checklist:
flake8 . --exclude=doc
mypy mapie examples --strict
pytest -vs --doctest-modules mapie
pytest -vs --doctest-modules --cov-branch --cov=mapie --pyargs mapie
cd doc; make clean; make html