Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmed + Tentative + Rejected not always equal to number of features in final iteration? #70

Closed
JohnStott opened this issue Feb 20, 2020 · 3 comments

Comments

@JohnStott
Copy link

JohnStott commented Feb 20, 2020

Hi,

it seems that throughout the _print_results method, the Confirmed + Tentative + Rejected is correct except for the final cycle in which it appears the "Tentative" value is incorrect. Could this mean self.support_weak_ is not always being updated correctly?

Here is an example of the output (see last cycle, where the values don't sum to the number of features?):

Iteration: 1 / 150
Confirmed: 0
Tentative: 47
Rejected: 0

....

Iteration: 148 / 150
Confirmed: 10
Tentative: 2
Rejected: 35

Iteration: 149 / 150
Confirmed: 10
Tentative: 2
Rejected: 35

BorutaPy finished running.

Iteration: 150 / 150
Confirmed: 10
Tentative: 1
Rejected: 35

@Naehil
Copy link

Naehil commented Mar 5, 2020

self.support_weak_, as well as self.support_ are updated correctly, however internally the number of rejected features are miscounted in the last step.

@danielhomola
Copy link
Collaborator

this is fixed now. pull latest master and should be good.

@FeFortti
Copy link

FeFortti commented Mar 18, 2024

This error is still happening. In practice, what is happening is what was mentioned by @Naehil ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants