New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging BorutaPy and Boruta-Shap #80
Comments
Sorry, completely forgot about this. I applaud your effort, but I'm worried about a couple of things here, maybe you can shine some light on these:
As I see in your other comment, you've |
No worries (a part of your post is missing, but here are some thoughts)
If you want so, you can choose from the Boruta-Shap package or some of the material of my PR (or not at all, but then we'll be left with different implementations of the globally same algorithm). |
Hi, Actually, the Shapley and permutation importances must be computed on unseen data, which is the case in my PR, not in Boruta_shap (I raised an issue on the boruta_shap github repo). |
Hi,
Ekeany just wrote a package (https://github.com/Ekeany/Boruta-Shap) with the same modifications that I made in the PR (#77).
To avoid duplicates and for the benefit of the community, it makes sense to merge those contributions. For the sake of clarity, under the scikit-learn-contrib umbrella.
Thanks!
KR
The text was updated successfully, but these errors were encountered: