Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return importance history from fit #88

Merged
merged 1 commit into from Oct 21, 2020

Conversation

davidfstein
Copy link
Contributor

Addresses issue #87. You already collect the importance histories. Simply adding it to the selector object so that it will be available after calling fit.

@danielhomola danielhomola merged commit ac23770 into scikit-learn-contrib:master Oct 21, 2020
@danielhomola
Copy link
Collaborator

can you please add it to the read me too?

danielhomola added a commit that referenced this pull request Oct 21, 2020
@davidfstein
Copy link
Contributor Author

Sorry I'm not sure how to edit a merged pull. Should I just create a new one with the updated README?

@danielhomola
Copy link
Collaborator

yeah sorry I closed it too soon.. could you please create a new one for the readme? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants