Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove **kwargs #168

Closed
glemaitre opened this issue Oct 25, 2016 · 1 comment
Closed

Remove **kwargs #168

glemaitre opened this issue Oct 25, 2016 · 1 comment
Assignees
@glemaitre
Labels
Type: Enhancement Indicates new feature requests
Projects
Release 0.2.0
Milestone
0.2.alpha

Comments

@glemaitre
Copy link
Member

Remove **kwargs from the different algorithms.

As @dvro mentioned, usually **kwargs can be replaced by passing a full classifier object.
@glemaitre glemaitre added the Type: Enhancement Indicates new feature requests label Oct 25, 2016
@glemaitre glemaitre added this to the 0.2.alpha milestone Oct 25, 2016
@chkoar
Copy link
Member

chkoar commented Oct 25, 2016

#109 (comment) Are we ok with this option? I think that it can work without breaking things.

@glemaitre glemaitre mentioned this issue Oct 27, 2016
Closed
@glemaitre glemaitre self-assigned this Oct 31, 2016
@glemaitre glemaitre mentioned this issue Oct 31, 2016
Closed
@glemaitre glemaitre modified the milestones: 0.3.alpha, 0.2.alpha Nov 2, 2016
@glemaitre glemaitre mentioned this issue Nov 3, 2016
Merged
@chkoar chkoar closed this as completed Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glemaitre glemaitre

Labels
Type: Enhancement Indicates new feature requests
Projects
No open projects
Release 0.2.0
MRG
Milestone
0.2.alpha
Development

No branches or pull requests
2 participants
@glemaitre @chkoar