Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awkward Comment on over_sampling.py file #22

Closed
clebsonc opened this issue Nov 24, 2015 · 2 comments
Closed

Awkward Comment on over_sampling.py file #22

clebsonc opened this issue Nov 24, 2015 · 2 comments
Assignees

Comments

@clebsonc
Copy link

I would like to know if is there anything wrong when generating the synthetic samples. I wonder this because of the words """ FIX THIS SHIT!!! """ on the comments from lines 254 to 256 as shown bellow:

        # --- Generating synthetic samples
        # Use static method make_samples to generate minority samples
        # FIX THIS SHIT!!!#
        sx, sy = self.make_samples(x=minx,
                                   nn_data=minx,
                                   y_type=self.minc,
                                   nn_num=nns,
                                   n_samples=int(self.ratio * len(miny)),
                                   step_size=1.0,
                                   random_state=self.rs,
                                   verbose=self.verbose)
@fmfn
Copy link
Collaborator

fmfn commented Nov 24, 2015

Haha, that's hilariously inappropriate. I don't believe there's any issues, it is likely some artifact of when the code was being refactored. AFAK all methods work as intended, despite awkward comments.

I'll fix that ASAP.

ps: Thanks for finding it.

@fmfn fmfn self-assigned this Nov 24, 2015
@glemaitre
Copy link
Member

It is fixed. Good to be closed.

@fmfn fmfn closed this as completed May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants