Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Release 0.6.2 #192

Merged
merged 2 commits into from Jan 17, 2022
Merged

Release 0.6.2 #192

merged 2 commits into from Jan 17, 2022

Conversation

StrikerRUS
Copy link
Contributor

@StrikerRUS StrikerRUS commented Jan 9, 2022

I believe Python 3.10 support that has been added recently (3afcb4a) deserves new release of the package. In new release we'll upload wheels for Python 3.10 making users' life easier.

Copy link
Member

@mblondel mblondel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! Thanks a lot!

@StrikerRUS StrikerRUS merged commit 4c6a2b4 into master Jan 17, 2022
@StrikerRUS StrikerRUS deleted the 0_6_2_release branch January 17, 2022 22:29
@StrikerRUS
Copy link
Contributor Author

I've just pushed commit with version update to indicate new development cycle directly into master: 216003c.

@StrikerRUS
Copy link
Contributor Author

@fabianp Could you please help to upload generated artifacts to PyPI like you did it last time?
https://github.com/scikit-learn-contrib/lightning/releases/tag/0.6.2
#184

@mblondel
Copy link
Member

Maybe we should automate the process like e.g. here.

@fabianp
Copy link
Member

fabianp commented Jan 22, 2022 via email

@StrikerRUS
Copy link
Contributor Author

Yeah, great idea!
I'll be happy to implement it but firstly we need to setup PyPI API token. Who has required rights for doing that?

@StrikerRUS
Copy link
Contributor Author

Please ping me when token is generated.

@fabianp
Copy link
Member

fabianp commented Jan 26, 2022

@StrikerRUS what is your pypi username? I'll add you to the owners on pypi

@StrikerRUS
Copy link
Contributor Author

My PyPI profile: https://pypi.org/user/StrikerRUS/.

@fabianp
Copy link
Member

fabianp commented Jan 27, 2022 via email

@StrikerRUS
Copy link
Contributor Author

just added you

Thank you! Accepted.
Will add auto-uploading functionality this weekend and keep you posted.

@StrikerRUS
Copy link
Contributor Author

Well, now along with GitHub Release new PyPI release is created after pushing new tag (I also modified tag matching regex a little bit to allow .devN and .postN releases: #195).

- name: Create PyPI Release
if: startsWith(github.ref, 'refs/tags/')
shell: bash
env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }}
run: |
pip install twine
rm -f dist/*.egg
twine upload --skip-existing dist/*

I'm really sorry for some mess in commits but I was struggling with accidentally uploaded .egg files. And had to create 0.6.2.post0 release to test new changes. Hope that's OK.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants