Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in flow of ts-changepoint notebook #475

Open
LacombeLouis opened this issue Jul 1, 2024 · 0 comments · May be fixed by #487
Open

Issue in flow of ts-changepoint notebook #475

LacombeLouis opened this issue Jul 1, 2024 · 0 comments · May be fixed by #487
Assignees
Labels
contributors Proposed by contributors. documentation Improvements or additions to documentation good first issue Good for newcomers
Milestone

Comments

@LacombeLouis
Copy link
Collaborator

Describe the bug
I get an error when running the ts-changepoint notebook. It looks like an issue with the flow of the notebook and not an issue with the conformal predictor itself.

To Reproduce

  • Run the notebook
  • Issue in the "Prediction interval with partial fit" section, when running "EnbPI with partial_fit, width optimization".

Expected behavior

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[23], [line 25](vscode-notebook-cell:?execution_count=23&line=25)
     [15](vscode-notebook-cell:?execution_count=23&line=15)     (
     [16](vscode-notebook-cell:?execution_count=23&line=16)         y_pred_pfit[step:step + gap],
     [17](vscode-notebook-cell:?execution_count=23&line=17)         y_pis_pfit[step:step + gap, :, :],
   (...)
     [22](vscode-notebook-cell:?execution_count=23&line=22)         optimize_beta=True
     [23](vscode-notebook-cell:?execution_count=23&line=23)     )
     [24](vscode-notebook-cell:?execution_count=23&line=24)     conformity_scores_pfit.append(mapie_enbpi.conformity_scores_)
---> [25](vscode-notebook-cell:?execution_count=23&line=25)     lower_quantiles_pfit.append(mapie_enbpi.lower_quantiles_)
     [26](vscode-notebook-cell:?execution_count=23&line=26)     higher_quantiles_pfit.append(mapie_enbpi.higher_quantiles_)
     [27](vscode-notebook-cell:?execution_count=23&line=27) coverage_pfit = regression_coverage_score(
     [28](vscode-notebook-cell:?execution_count=23&line=28)     y_test, y_pis_pfit[:, 0, 0], y_pis_pfit[:, 1, 0]
     [29](vscode-notebook-cell:?execution_count=23&line=29) )

AttributeError: 'MapieTimeSeriesRegressor' object has no attribute 'lower_quantiles_'

Screenshots
Screenshot 2024-07-01 at 11 45 01

@LacombeLouis LacombeLouis added documentation Improvements or additions to documentation contributors Proposed by contributors. labels Jul 1, 2024
@LacombeLouis LacombeLouis added this to Need triage in Developments via automation Jul 1, 2024
@LacombeLouis LacombeLouis added the good first issue Good for newcomers label Jul 15, 2024
@LacombeLouis LacombeLouis added this to the 0.9.0 milestone Jul 15, 2024
@BaptisteCalot BaptisteCalot linked a pull request Jul 19, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributors Proposed by contributors. documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
Developments
Need triage
Development

Successfully merging a pull request may close this issue.

2 participants