Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_estimator not valid for vectorizers #29

Closed
ysig opened this issue Dec 1, 2017 · 3 comments
Closed

test_estimator not valid for vectorizers #29

ysig opened this issue Dec 1, 2017 · 3 comments

Comments

@ysig
Copy link

ysig commented Dec 1, 2017

We are currently developing a transformer compatible with sk-learn that behaves
as a vectorizer for graph type object. The test estimator method injects arrays of
n by m which are not valid to our current input.Tfidf vectorizer supports also a kind
o input that is not an array of n by m features, but rather a vector of strings.
Can the check_estimator constraints be softened for a vectorizer type transformer?

return check_estimator(TemplateEstimator)

@agramfort
Copy link
Member

send us a PR

@ysig
Copy link
Author

ysig commented Dec 4, 2017

Ok, the personal repo is the link that follows. The library is not yet mature, but the essential part is there and concerns the input form of the graph_kernel file. It is just an iterable (a vector) of objects (in our case a list of lists) where inside each sub-list we expect as elements a graph type input and optionally graph labels. Init function is used to set the kernel function applied in "transform".
https://github.com/ysig/GraKeL
https://github.com/ysig/GraKeL/blob/master/grakel/graph_kernels.py

@glemaitre
Copy link
Member

Actually this should be reported to scikit-learn since that we want the check_estimator to be flexible enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants